Fix compilation with ikos-scan-cc (#17). #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfiderek
changed the title
|
Can you modify the commit message to close issue #17? Thanks! |
xfiderek
changed the title
|
@ivanperez-keera done! |
Building cobra_vendor package fails when ikos-scan-cc is used as a compiler. For a command like: ``` ikos-scan-cc -Wall -pedantic -Werror -Wshadow -O2 -DYY_NO_INPUT -I. -std=c99 -o scope_check scope_check.c cwe_util.c c.ar -pthread ``` the following error message is printed: ``` clang: error: c.ar: 'linker' input unused [-Werror,-Wunused-command-line-argument] ``` Changing the end of the compile command from `c.ar -pthread` to `-Wl,c.ar -pthread` fixes the issue. This commit addresses the issue by modifying the linker flags in the CMakeLists.txt.
ivanperez-keera
force-pushed
the
fix_ikos
branch
from
d0571a6
to
fbe2b4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes compilation with ikos-scan-cc compiler, by modifying linker flags. Refer to problem B described in space-ros/docker#138 for more details. I have verified that compilation works fine with
gccandclangafter adding these flags.Of course, I can create a separate issue for this in ament cobra repo if needed. I am also open to alternative solutions (e.g. modifying cobra makefile).